Report CompileTimeErrorCode.DUPLICATE_PART when not only URI, but even Source is the same.

Report CompileTimeErrorCode.DUPLICATE_PART when not only URI, but even Source is the same.

There is one usecase when strongly speaking the error should not be
reported - when the part is empty. But that still does not seem practical.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27509

Committed: https://github.com/dart-lang/sdk/commit/59e8af70476a3806b813dbb9f386e32f0ad784ae

[Brian Wilkerson, 2016-10-06 22:14:11]

lgtm

https://codereview.chromium.org/2401783002/diff/1/pkg/analyzer/lib/src/error/...
File pkg/analyzer/lib/src/error/codes.dart (right):

https://codereview.chromium.org/2401783002/diff/1/pkg/analyzer/lib/src/error/...
pkg/analyzer/lib/src/error/codes.dart:759: const
CompileTimeErrorCode('DUPLICATE_PART', 'Duplicate part');
I think the old message was better. I think it would be fine if the URI we use
for the message was the resolved URI rather than the string literal from the
directive.

https://codereview.chromium.org/2401783002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/2401783002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:1545: [directive.uriContent]));
We should either restore the argument to the message (my preference) or remove
it here.

[scheglov, 2016-10-07 03:44:33]

Description was changed from

==========
Report CompileTimeErrorCode.DUPLICATE_PART when not only URI, but even Source is
the same.

There is one usecase when strongly speaking the error should not be
reported - when the part is empty. But that still does not seem practical.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27509
==========

to

==========
Report CompileTimeErrorCode.DUPLICATE_PART when not only URI, but even Source is
the same.

There is one usecase when strongly speaking the error should not be
reported - when the part is empty. But that still does not seem practical.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27509

Committed:
https://github.com/dart-lang/sdk/commit/59e8af70476a3806b813dbb9f386e32f0ad784ae
==========

[scheglov, 2016-10-07 03:44:35]

Committed patchset #1 (id:1) manually as
59e8af70476a3806b813dbb9f386e32f0ad784ae (presubmit successful).