Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Issue 2401763003: Fix background page loading (Closed)

Created:
4 years, 2 months ago by kjlubick
Modified:
4 years, 2 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Fix background page loading You should now be able to open pages in a new tab and they will start loading. I was able to get rid of the popup that would happen sometimes by being a bit more patient on the auth library to load its thing. The main culprit was the fact that we were waiting until the auth-signin's attached phase to do anything, which apparently requires tab focus. The ready phase can fire while the tab is still hidden, so we use that instead. I also made the token "offline", seems to have helped with more consistent credential management by the google-signin-aware element. It may have been unnecessary, but it works nonetheless. BUG=653703 Committed: https://github.com/luci/luci-py/commit/39e913eeed7f17dc3147c588ec7cb85125742056

Patch Set 1 #

Patch Set 2 : Get rid of popup/signin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/swarming/elements/res/imp/common/auth-signin.html View 1 2 chunks +14 lines, -18 lines 0 comments Download
M appengine/swarming/elements/res/imp/taskpage/task-page.html View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
kjlubick
Try it out at https://2389-44bbd1f-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newui/
4 years, 2 months ago (2016-10-07 17:57:02 UTC) #5
jcgregorio
lgtm
4 years, 2 months ago (2016-10-07 17:59:09 UTC) #6
KevinL
lgtm
4 years, 2 months ago (2016-10-07 17:59:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401763003/20001
4 years, 2 months ago (2016-10-07 17:59:47 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 18:03:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/39e913eeed7f17dc3147c588ec7cb85125742056

Powered by Google App Engine
This is Rietveld 408576698