Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2401753002: A forced break inside a break-inside:avoid object may make it fit where it is. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A forced break inside a break-inside:avoid object may make it fit where it is. If an object with break-inside:avoid is taller than what fits in the current fragmentainer, but it has a forced break before we get to the end of the fragmentainer, we don't have to push the object to the next one, since what's before the forced break fits fine where it is. BUG=533736 Committed: https://crrev.com/458533ce55b647ead038ff602228686cb8ecb182 Cr-Commit-Position: refs/heads/master@{#423884}

Patch Set 1 #

Patch Set 2 : Volvo lastvagnar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, --1 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/break-inside-avoid-with-forced-break.html View 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fragmentation/break-inside-avoid-with-forced-break-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 5 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
mstensho (USE GERRIT)
It's corner-case Friday again!
4 years, 2 months ago (2016-10-07 09:29:04 UTC) #10
eae
LGTM
4 years, 2 months ago (2016-10-07 16:43:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401753002/20001
4 years, 2 months ago (2016-10-07 16:43:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 16:49:38 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 16:51:41 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/458533ce55b647ead038ff602228686cb8ecb182
Cr-Commit-Position: refs/heads/master@{#423884}

Powered by Google App Engine
This is Rietveld 408576698