Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2401743003: Recommit and fix of "Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyM… (Closed)

Created:
4 years, 2 months ago by ljusten (tachyonic)
Modified:
4 years, 2 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, cbentzel+watch_chromium.org, pam+watch_chromium.org, tnagel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Recommit and fix of "Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyMode policy" Git hash: c42c0dddcb3c630cb30096d16a4485bd1025eccc Link: https://codereview.chromium.org/2239753002/ The CL was reverted because of a timeout in the PolicyTest.ForceSafeSearch browser test. The test was doing a lot of calls to the slow CheckSafeSearch function. To fix this, the browser test is split into two separate tests: LegacySafeSearch verifies that prefs are set properly. ForceGoogleSafeSearch verifies that safe search actually is in effect depending on the pref. TBR=tnagel@chromium.org BUG=590478 Committed: https://crrev.com/98684cb7910faea91679c00a54484237e386a099 Cr-Commit-Position: refs/heads/master@{#424413}

Patch Set 1 : Recommit of https://codereview.chromium.org/2239753002/ #

Patch Set 2 : Split unit test up into two, addressed old comment #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -165 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 8 chunks +23 lines, -17 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 3 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/net/safe_search_util.h View 1 chunk +22 lines, -6 lines 0 comments Download
M chrome/browser/net/safe_search_util.cc View 3 chunks +28 lines, -14 lines 0 comments Download
M chrome/browser/net/safe_search_util_unittest.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 5 chunks +53 lines, -8 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 3 chunks +104 lines, -30 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store.cc View 4 chunks +30 lines, -16 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_browsertest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 2 chunks +11 lines, -4 lines 0 comments Download
M components/policy/resources/policy_templates.json View 3 chunks +57 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
ljusten (tachyonic)
Thiemo, PTAL
4 years, 2 months ago (2016-10-07 12:34:54 UTC) #2
Thiemo Nagel
lgtm
4 years, 2 months ago (2016-10-10 14:11:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401743003/40001
4 years, 2 months ago (2016-10-11 10:42:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/83975)
4 years, 2 months ago (2016-10-11 10:50:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401743003/40001
4 years, 2 months ago (2016-10-11 11:59:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/83994)
4 years, 2 months ago (2016-10-11 12:08:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401743003/40001
4 years, 2 months ago (2016-10-11 13:21:01 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-11 13:26:50 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 13:29:28 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/98684cb7910faea91679c00a54484237e386a099
Cr-Commit-Position: refs/heads/master@{#424413}

Powered by Google App Engine
This is Rietveld 408576698