Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2401733002: Revert "Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyMode policy" (Closed)

Created:
4 years, 2 months ago by nasko
Modified:
4 years, 2 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, cbentzel+watch_chromium.org, pam+watch_chromium.org, tnagel+watch_chromium.org, asvitkine+watch_chromium.org, ljusten (tachyonic)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyMode policy" This reverts commit c42c0dddcb3c630cb30096d16a4485bd1025eccc. Reason: The PolicyTest.ForceSafeSearch test is failing on Windows bots. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/53375 TBR=ljusten@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=590478 Committed: https://chromium.googlesource.com/chromium/src/+/e0272627e60748462851aae327c242599066b80e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -374 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 6 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 8 chunks +17 lines, -23 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 4 chunks +19 lines, -20 lines 0 comments Download
M chrome/browser/net/safe_search_util.h View 1 chunk +6 lines, -22 lines 0 comments Download
M chrome/browser/net/safe_search_util.cc View 3 chunks +14 lines, -28 lines 0 comments Download
M chrome/browser/net/safe_search_util_unittest.cc View 1 chunk +10 lines, -13 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 5 chunks +8 lines, -53 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +26 lines, -77 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store.cc View 4 chunks +16 lines, -30 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc View 4 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service_browsertest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 2 chunks +4 lines, -11 lines 0 comments Download
M components/policy/resources/policy_templates.json View 3 chunks +9 lines, -57 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0272627e60748462851aae327c242599066b80e Cr-Commit-Position: refs/heads/master@{#423637}
4 years, 2 months ago (2016-10-06 19:56:12 UTC) #3
nasko
Committed patchset #1 (id:1) manually as e0272627e60748462851aae327c242599066b80e (presubmit successful).
4 years, 2 months ago (2016-10-06 19:57:27 UTC) #5
Thiemo Nagel
Nasko, is there a specific reason why you didn't click "Revert Patchset" on the original ...
4 years, 2 months ago (2016-10-17 09:40:37 UTC) #7
Thiemo Nagel
Nasko, is there a specific reason why you didn't click "Revert Patchset" on the original ...
4 years, 2 months ago (2016-10-17 09:40:38 UTC) #8
nasko
On 2016/10/17 09:40:38, Thiemo Nagel (slow) wrote: > Nasko, is there a specific reason why ...
4 years, 2 months ago (2016-10-17 16:56:14 UTC) #9
Thiemo Nagel
4 years, 2 months ago (2016-10-17 17:00:09 UTC) #10
Message was sent while issue was closed.
> I am well aware that it is best to track through reverts directly. I don't
> recall what the exact reason I had to revert it manually was, but I wouldn't
> have done it if the automated way worked.

In that case, please disregard my message. :)

Powered by Google App Engine
This is Rietveld 408576698