Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2401663002: [Origin Trials] Remove unused setFeatureBindingsInstalled/featureBindingsInstalled methods (Closed)

Created:
4 years, 2 months ago by iclelland
Modified:
4 years, 2 months ago
Reviewers:
haraken, chasej
CC:
chromium-reviews, blink-reviews, chasej+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Origin Trials] Remove unused setFeatureBindingsInstalled/featureBindingsInstalled methods These two accessors, and the HashSet underlying them, could have been removed earlier; they're unused now, and this CL cleans them up. R=chasej@chromium.org Committed: https://crrev.com/2f18c6cbb4f18ea0735abb7c55110e61971d9732 Cr-Commit-Position: refs/heads/master@{#423860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
iclelland
+r chasej, can you take a look?
4 years, 2 months ago (2016-10-06 15:04:50 UTC) #3
chasej
lgtm
4 years, 2 months ago (2016-10-06 15:18:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401663002/1
4 years, 2 months ago (2016-10-06 17:04:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/275487)
4 years, 2 months ago (2016-10-06 17:13:53 UTC) #10
iclelland
+r haraken as OWNER, can you take a look? Thanks!
4 years, 2 months ago (2016-10-06 17:38:02 UTC) #12
haraken
LGTM
4 years, 2 months ago (2016-10-06 23:42:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401663002/1
4 years, 2 months ago (2016-10-07 14:54:26 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:59:51 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 15:02:23 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f18c6cbb4f18ea0735abb7c55110e61971d9732
Cr-Commit-Position: refs/heads/master@{#423860}

Powered by Google App Engine
This is Rietveld 408576698