[turbofan] Discard the shared code entry in the optimized code map.

[turbofan] Discard the shared code entry in the optimized code map.

At one time, we hoped to generate the same code for different
native contexts. But in truth, much performance comes from optimizing
on the native context. Now we abandon this pathway.

BUG=

Committed: https://crrev.com/55af3c44c99a6e4cd6d53df775023d760ad2b2c3
Cr-Commit-Position: refs/heads/master@{#40079}

[mvstanton, 2016-10-06 15:03:19]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 15:03:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-10-06 15:07:16]

mvstanton@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[mvstanton, 2016-10-06 15:07:16]

Hi Michael, here is the CL we discussed, thx for the look,
--Mike

[mvstanton, 2016-10-06 18:13:48]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 18:13:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 18:41:13]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-10-07 09:23:46]

LGTM. Nice, I like it. Just one comment.

https://codereview.chromium.org/2401653002/diff/20001/src/builtins/arm/builti...
File src/builtins/arm/builtins-arm.cc (right):

https://codereview.chromium.org/2401653002/diff/20001/src/builtins/arm/builti...
src/builtins/arm/builtins-arm.cc:1447: __
bind(&install_optimized_code_and_tailcall);
nit: The {install_optimized_code_and_tailcall} label seems to be unused bu now.
Let's drop the label as well as the binding call. Probably applies to all
architectures.

[mvstanton, 2016-10-07 09:46:08]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[mvstanton, 2016-10-07 09:46:12]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-10-07 09:46:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2401653002/#ps40001
(title: "Comments and REBASE.")

[commit-bot: I haz the power, 2016-10-07 09:46:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-10-07 09:46:27]

thanks!
--Mike

https://codereview.chromium.org/2401653002/diff/20001/src/builtins/arm/builti...
File src/builtins/arm/builtins-arm.cc (right):

https://codereview.chromium.org/2401653002/diff/20001/src/builtins/arm/builti...
src/builtins/arm/builtins-arm.cc:1447: __
bind(&install_optimized_code_and_tailcall);
On 2016/10/07 09:23:46, Michael Starzinger wrote:
> nit: The {install_optimized_code_and_tailcall} label seems to be unused bu
now.
> Let's drop the label as well as the binding call. Probably applies to all
> architectures.

Good catch, thanks! Done.

[commit-bot: I haz the power, 2016-10-07 09:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 09:58:50]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25911)

[mvstanton, 2016-10-07 10:01:21]

mvstanton@chromium.org changed reviewers:
+ ishell@chromium.org

[mvstanton, 2016-10-07 10:01:22]

Hi Igor,
Could you have a quick look at the file in /crankshaft?

[Igor Sheludko, 2016-10-07 10:41:02]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-10-07 10:41:02]

lgtm

[commit-bot: I haz the power, 2016-10-07 10:41:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 10:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 10:45:01]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25921)

[Benedikt Meurer, 2016-10-07 10:48:19]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-10-07 10:48:20]

LGTM (rubber-stamped)

[mvstanton, 2016-10-07 10:59:38]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2016-10-07 10:59:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 11:01:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-07 11:02:16]

Description was changed from

==========
[turbofan] Discard the shared code entry in the optimized code map.

At one time, we hoped to generate the same code for different
native contexts. But in truth, much performance comes from optimizing
on the native context. Now we abandon this pathway.

BUG=
==========

to

==========
[turbofan] Discard the shared code entry in the optimized code map.

At one time, we hoped to generate the same code for different
native contexts. But in truth, much performance comes from optimizing
on the native context. Now we abandon this pathway.

BUG=

Committed: https://crrev.com/55af3c44c99a6e4cd6d53df775023d760ad2b2c3
Cr-Commit-Position: refs/heads/master@{#40079}
==========

[commit-bot: I haz the power, 2016-10-07 11:02:18]

Patchset 3 (id:??) landed as
https://crrev.com/55af3c44c99a6e4cd6d53df775023d760ad2b2c3
Cr-Commit-Position: refs/heads/master@{#40079}

[mvstanton, 2016-10-07 12:07:35]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2403453002/ by mvstanton@chromium.org.

The reason for reverting is: Possible GCSTRESS failure, investigating..

[Michael Achenbach, 2016-10-07 12:24:22]

On 2016/10/07 12:07:35, mvstanton wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2403453002/ by mailto:mvstanton@chromium.org.
> 
> The reason for reverting is: Possible GCSTRESS failure, investigating..

Did this hit any new gc stress error?
Note: https://bugs.chromium.org/p/v8/issues/detail?id=5451
That's under investigation. Then we had also 
https://bugs.chromium.org/p/v8/issues/detail?id=5492