Create user gesture indicator for pointerup

third_party/WebKit/Source/core/input/PointerEventManager.cpp

Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
index 21ce995d0f67a222d0160e4a6e62a6fa861c49a5..5142eceb2e4f30b65595de606e8f208e49115ce9 100644
--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
@@ -168,6 +168,12 @@ WebInputEventResult PointerEventManager::dispatchPointerEvent(
       UseCounter::count(m_frame->document(),
                         UseCounter::PointerEventDispatchPointerDown);
 
+    std::unique_ptr<UserGestureIndicator> gestureIndicator;
+    if (eventType == EventTypeNames::pointerup) {
+      gestureIndicator =
+          wrapUnique(new UserGestureIndicator(DefinitelyProcessingUserGesture));

[mustaq, 2016/10/07 19:06:21]

Can't we make this a one-liner like this?
  if(pointerup)
    UserGestureIndicator gestureIndicator(Definitely...);

[Navid Zolghadr, 2016/10/11 13:19:26]

That wouldn't work. Because the variable will go out of scope as soon as if ends
and the gesture indicator will be destroyed. I need a variable here that is
created conditionally and is alive until the end of the function.

Beside that Dave wanted me to use the token in TouchEventManager which I'm
trying to understand what the logic is there. So this code might change a
little. I'll try to finish up the updates and send a new patch today.

[Rick Byers, 2016/10/11 15:11:52]

Note that you can also avoid indirection via a unique_ptr by just making the
constructor argument conditional.  See this related pending overhaul:
https://codereview.chromium.org/2401123002/

[Navid Zolghadr, 2016/10/12 15:18:01]

Since the other change landed before this if I add more changes to this CL I
will get more conflicts when merging to 55. Following our offline discussion
I'll keep this part as is.

+    }
+
     DispatchEventResult dispatchResult = target->dispatchEvent(pointerEvent);
     return EventHandlingUtil::toWebInputEventResult(dispatchResult);
   }