Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/bootstrapper.cc

Issue 2401643002: [regexp] Port split (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/base/ieee754.h" 9 #include "src/base/ieee754.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1728 matching lines...) Expand 10 before | Expand all | Expand 10 after
1739 Builtins::kRegExpPrototypeMatch, 1, false); 1739 Builtins::kRegExpPrototypeMatch, 1, false);
1740 InstallFunction(prototype, fun, factory->match_symbol(), DONT_ENUM); 1740 InstallFunction(prototype, fun, factory->match_symbol(), DONT_ENUM);
1741 } 1741 }
1742 1742
1743 { 1743 {
1744 Handle<JSFunction> fun = SimpleCreateFunction( 1744 Handle<JSFunction> fun = SimpleCreateFunction(
1745 isolate, factory->InternalizeUtf8String("[Symbol.search]"), 1745 isolate, factory->InternalizeUtf8String("[Symbol.search]"),
1746 Builtins::kRegExpPrototypeSearch, 1, false); 1746 Builtins::kRegExpPrototypeSearch, 1, false);
1747 InstallFunction(prototype, fun, factory->search_symbol(), DONT_ENUM); 1747 InstallFunction(prototype, fun, factory->search_symbol(), DONT_ENUM);
1748 } 1748 }
1749
1750 {
1751 Handle<JSFunction> fun = SimpleCreateFunction(
1752 isolate, factory->InternalizeUtf8String("[Symbol.split]"),
1753 Builtins::kRegExpPrototypeSplit, 2, false);
1754 InstallFunction(prototype, fun, factory->split_symbol(), DONT_ENUM);
1755 }
1749 } 1756 }
1750 1757
1751 { 1758 {
1752 // RegExp getters and setters. 1759 // RegExp getters and setters.
1753 1760
1754 // TODO(jgruber): This should really be DONT_ENUM | DONT_DELETE. 1761 // TODO(jgruber): This should really be DONT_ENUM | DONT_DELETE.
1755 // However, that currently breaks layout test expectations. Note that 1762 // However, that currently breaks layout test expectations. Note that
1756 // Firefox sets a couple of these as enumerable. 1763 // Firefox sets a couple of these as enumerable.
1757 // On the other hand, installing attributes as DONT_ENUM matches the draft 1764 // On the other hand, installing attributes as DONT_ENUM matches the draft
1758 // specification at 1765 // specification at
(...skipping 2621 matching lines...) Expand 10 before | Expand all | Expand 10 after
4380 } 4387 }
4381 4388
4382 4389
4383 // Called when the top-level V8 mutex is destroyed. 4390 // Called when the top-level V8 mutex is destroyed.
4384 void Bootstrapper::FreeThreadResources() { 4391 void Bootstrapper::FreeThreadResources() {
4385 DCHECK(!IsActive()); 4392 DCHECK(!IsActive());
4386 } 4393 }
4387 4394
4388 } // namespace internal 4395 } // namespace internal
4389 } // namespace v8 4396 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698