Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: src/bootstrapper.cc

Issue 2401643002: [regexp] Port split (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | src/builtins/builtins-regexp.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/base/ieee754.h" 9 #include "src/base/ieee754.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1719 matching lines...) Expand 10 before | Expand all | Expand 10 after
1730 Builtins::kRegExpPrototypeMatch, 1, false); 1730 Builtins::kRegExpPrototypeMatch, 1, false);
1731 InstallFunction(prototype, fun, factory->match_symbol(), DONT_ENUM); 1731 InstallFunction(prototype, fun, factory->match_symbol(), DONT_ENUM);
1732 } 1732 }
1733 1733
1734 { 1734 {
1735 Handle<JSFunction> fun = SimpleCreateFunction( 1735 Handle<JSFunction> fun = SimpleCreateFunction(
1736 isolate, factory->InternalizeUtf8String("[Symbol.search]"), 1736 isolate, factory->InternalizeUtf8String("[Symbol.search]"),
1737 Builtins::kRegExpPrototypeSearch, 1, false); 1737 Builtins::kRegExpPrototypeSearch, 1, false);
1738 InstallFunction(prototype, fun, factory->search_symbol(), DONT_ENUM); 1738 InstallFunction(prototype, fun, factory->search_symbol(), DONT_ENUM);
1739 } 1739 }
1740
1741 {
1742 Handle<JSFunction> fun = SimpleCreateFunction(
1743 isolate, factory->InternalizeUtf8String("[Symbol.split]"),
1744 Builtins::kRegExpPrototypeSplit, 2, false);
1745 InstallFunction(prototype, fun, factory->split_symbol(), DONT_ENUM);
1746 }
1740 } 1747 }
1741 1748
1742 { 1749 {
1743 // RegExp getters and setters. 1750 // RegExp getters and setters.
1744 1751
1745 // TODO(jgruber): This should really be DONT_ENUM | DONT_DELETE. 1752 // TODO(jgruber): This should really be DONT_ENUM | DONT_DELETE.
1746 // However, that currently breaks layout test expectations. Note that 1753 // However, that currently breaks layout test expectations. Note that
1747 // Firefox sets a couple of these as enumerable. 1754 // Firefox sets a couple of these as enumerable.
1748 // On the other hand, installing attributes as DONT_ENUM matches the draft 1755 // On the other hand, installing attributes as DONT_ENUM matches the draft
1749 // specification at 1756 // specification at
(...skipping 2602 matching lines...) Expand 10 before | Expand all | Expand 10 after
4352 } 4359 }
4353 4360
4354 4361
4355 // Called when the top-level V8 mutex is destroyed. 4362 // Called when the top-level V8 mutex is destroyed.
4356 void Bootstrapper::FreeThreadResources() { 4363 void Bootstrapper::FreeThreadResources() {
4357 DCHECK(!IsActive()); 4364 DCHECK(!IsActive());
4358 } 4365 }
4359 4366
4360 } // namespace internal 4367 } // namespace internal
4361 } // namespace v8 4368 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | src/builtins/builtins-regexp.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698