Index: cc/trees/layer_tree_host_unittest.cc |
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc |
index 7a4a305d1f0c40da59a179c9fc347571abcaeaf4..87a643eb48ddde201bae3f899d1ea506cd8b7825 100644 |
--- a/cc/trees/layer_tree_host_unittest.cc |
+++ b/cc/trees/layer_tree_host_unittest.cc |
@@ -4500,11 +4500,11 @@ class LayerTreeHostTestBreakSwapPromise : public LayerTreeHostTest { |
} |
{ |
- // The second commit aborts. |
+ // The second commit is aborted since it contains no updates. |
base::AutoLock lock(swap_promise_result_[1].lock); |
EXPECT_FALSE(swap_promise_result_[1].did_swap_called); |
EXPECT_TRUE(swap_promise_result_[1].did_not_swap_called); |
- EXPECT_EQ(SwapPromise::COMMIT_FAILS, swap_promise_result_[1].reason); |
+ EXPECT_EQ(SwapPromise::COMMIT_NO_UPDATE, swap_promise_result_[1].reason); |
EXPECT_TRUE(swap_promise_result_[1].dtor_called); |
} |
@@ -4527,6 +4527,50 @@ class LayerTreeHostTestBreakSwapPromise : public LayerTreeHostTest { |
// TODO(miletus): Flaky test: crbug.com/393995 |
// MULTI_THREAD_TEST_F(LayerTreeHostTestBreakSwapPromise); |
+class LayerTreeHostTestBreakSwapPromiseForAbortedCommit |
+ : public LayerTreeHostTest { |
+ protected: |
+ LayerTreeHostTestBreakSwapPromiseForAbortedCommit() : commit_count_(0) {} |
+ |
+ virtual void BeginTest() OVERRIDE { PostSetNeedsCommitToMainThread(); } |
+ |
+ virtual void WillBeginMainFrame() OVERRIDE { |
+ layer_tree_host()->SetDeferCommits(true); |
+ layer_tree_host()->SetNeedsCommit(); |
+ } |
+ |
+ virtual void DidDeferCommit() OVERRIDE { |
+ layer_tree_host()->SetVisible(false); |
+ layer_tree_host()->SetDeferCommits(false); |
+ |
+ scoped_ptr<SwapPromise> swap_promise( |
+ new TestSwapPromise(&swap_promise_result_)); |
+ layer_tree_host()->QueueSwapPromise(swap_promise.Pass()); |
+ } |
+ |
+ virtual void DidCommit() OVERRIDE { PostSetNeedsCommitToMainThread(); } |
+ |
+ virtual void BeginMainFrameAbortedOnThread(LayerTreeHostImpl* host_impl, |
+ bool did_handle) OVERRIDE { |
+ EndTest(); |
+ } |
+ |
+ virtual void AfterTest() OVERRIDE { |
+ { |
+ base::AutoLock lock(swap_promise_result_.lock); |
+ EXPECT_FALSE(swap_promise_result_.did_swap_called); |
+ EXPECT_TRUE(swap_promise_result_.did_not_swap_called); |
+ EXPECT_EQ(SwapPromise::COMMIT_FAILS, swap_promise_result_.reason); |
+ EXPECT_TRUE(swap_promise_result_.dtor_called); |
+ } |
+ } |
+ |
+ int commit_count_; |
+ TestSwapPromiseResult swap_promise_result_; |
+}; |
+ |
+MULTI_THREAD_TEST_F(LayerTreeHostTestBreakSwapPromiseForAbortedCommit); |
+ |
class SimpleSwapPromiseMonitor : public SwapPromiseMonitor { |
public: |
SimpleSwapPromiseMonitor(LayerTreeHost* layer_tree_host, |