Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: content/renderer/gpu/frame_swap_message_queue_unittest.cc

Issue 240163005: Deliver IPC messages together with SwapCompositorFrame (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: feedback + add more testing Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/renderer/gpu/frame_swap_message_queue.h"
6 #include "ipc/ipc_message.h"
7 #include "testing/gtest/include/gtest/gtest.h"
8
9 namespace content {
10
11 class FrameSwapMessageQueueTest : public testing::Test {
12 public:
13 FrameSwapMessageQueueTest()
14 : first_message_(41, 0, IPC::Message::PRIORITY_NORMAL),
15 second_message_(42, 0, IPC::Message::PRIORITY_NORMAL),
16 third_message_(43, 0, IPC::Message::PRIORITY_NORMAL),
17 queue_(new FrameSwapMessageQueue()) {}
18
19 protected:
20 void QueueMessage(scoped_ptr<IPC::Message> msg) {
21 queue_->QueueMessage(msg.Pass());
22 }
23 void QueueMessageForFrame(int source_frame_number,
24 scoped_ptr<IPC::Message> msg) {
25 queue_->QueueMessageForFrame(source_frame_number, msg.Pass(), NULL);
26 }
27 void QueueMessageForFrame(int source_frame_number,
28 scoped_ptr<IPC::Message> msg,
29 bool* first) {
30 queue_->QueueMessageForFrame(source_frame_number, msg.Pass(), first);
31 }
32 void DrainMessages(int source_frame_number,
33 ScopedVector<IPC::Message>* messages) {
34 queue_->AdvanceToFrame(source_frame_number);
35 scoped_ptr<FrameSwapMessageQueue::SendMessageScope> send_message_scope =
36 queue_->AcquireSendMessageScope();
37 queue_->DrainMessages(messages);
38 }
39 void DrainMessages(ScopedVector<IPC::Message>* messages) {
40 scoped_ptr<FrameSwapMessageQueue::SendMessageScope> send_message_scope =
41 queue_->AcquireSendMessageScope();
42 queue_->DrainMessages(messages);
43 }
44 bool HasMessageForId(const ScopedVector<IPC::Message>& messages,
45 int routing_id) {
46 for (ScopedVector<IPC::Message>::const_iterator i = messages.begin();
47 i != messages.end();
48 ++i) {
49 if ((*i)->routing_id() == routing_id)
50 return true;
51 }
52 return false;
53 }
54 scoped_ptr<IPC::Message> CloneMessage(const IPC::Message& other) {
55 return make_scoped_ptr(new IPC::Message(other)).Pass();
56 }
57
58 IPC::Message first_message_;
59 IPC::Message second_message_;
60 IPC::Message third_message_;
61 scoped_refptr<FrameSwapMessageQueue> queue_;
62 };
63
64 TEST_F(FrameSwapMessageQueueTest, TestEmptyQueueDrain) {
65 ScopedVector<IPC::Message> messages;
66
67 DrainMessages(&messages);
68 ASSERT_TRUE(messages.empty());
69 }
70
71 TEST_F(FrameSwapMessageQueueTest, TestEmpty) {
72 ScopedVector<IPC::Message> messages;
73 ASSERT_TRUE(queue_->Empty());
74 QueueMessage(CloneMessage(first_message_));
75 ASSERT_FALSE(queue_->Empty());
76 DrainMessages(&messages);
77 ASSERT_TRUE(queue_->Empty());
78 QueueMessageForFrame(1, CloneMessage(first_message_));
79 ASSERT_FALSE(queue_->Empty());
80 queue_->AdvanceToFrame(1);
81 ASSERT_FALSE(queue_->Empty());
82 }
83
84 TEST_F(FrameSwapMessageQueueTest, TestQueueMessageFirst) {
85 ScopedVector<IPC::Message> messages;
86 bool first = false;
87
88 QueueMessageForFrame(1, CloneMessage(first_message_), &first);
89 ASSERT_TRUE(first);
90 QueueMessageForFrame(1, CloneMessage(second_message_), &first);
91 ASSERT_FALSE(first);
92 QueueMessageForFrame(2, CloneMessage(first_message_), &first);
93 ASSERT_TRUE(first);
94
95 DrainMessages(4, &messages);
96 QueueMessageForFrame(4, CloneMessage(first_message_), &first);
97 ASSERT_TRUE(first);
98 }
99
100 TEST_F(FrameSwapMessageQueueTest, TestQueuedMessageSentWithNextFrame) {
101 ScopedVector<IPC::Message> messages;
102
103 DrainMessages(1, &messages);
104 QueueMessage(CloneMessage(first_message_));
105 DrainMessages(2, &messages);
106 ASSERT_EQ(1u, messages.size());
107 ASSERT_EQ(first_message_.routing_id(), messages.front()->routing_id());
108 messages.clear();
109
110 DrainMessages(2, &messages);
111 ASSERT_TRUE(messages.empty());
112 }
113
114 TEST_F(FrameSwapMessageQueueTest, TestQueueMessageSentWithCurrentFrame) {
115 ScopedVector<IPC::Message> messages;
116
117 DrainMessages(1, &messages);
118 QueueMessage(CloneMessage(first_message_));
119 DrainMessages(1, &messages);
120 ASSERT_EQ(1u, messages.size());
121 ASSERT_EQ(first_message_.routing_id(), messages.front()->routing_id());
122 messages.clear();
123
124 DrainMessages(1, &messages);
125 ASSERT_TRUE(messages.empty());
126 }
127
128 TEST_F(FrameSwapMessageQueueTest, TestDrainsMessagesForCorrespondingFrames) {
129 ScopedVector<IPC::Message> messages;
130
131 QueueMessageForFrame(1, CloneMessage(first_message_));
132 QueueMessageForFrame(2, CloneMessage(second_message_));
133 QueueMessageForFrame(3, CloneMessage(third_message_));
134 DrainMessages(0, &messages);
135 ASSERT_TRUE(messages.empty());
136
137 DrainMessages(2, &messages);
138 ASSERT_EQ(2u, messages.size());
139 ASSERT_TRUE(HasMessageForId(messages, first_message_.routing_id()));
140 ASSERT_TRUE(HasMessageForId(messages, second_message_.routing_id()));
141 messages.clear();
142
143 DrainMessages(2, &messages);
144 ASSERT_TRUE(messages.empty());
145
146 DrainMessages(5, &messages);
147 ASSERT_EQ(1u, messages.size());
148 ASSERT_EQ(third_message_.routing_id(), messages.front()->routing_id());
149 }
150
151 TEST_F(FrameSwapMessageQueueTest, TestQueueMessagePreservesFifoOrdering) {
152 ScopedVector<IPC::Message> messages;
153
154 QueueMessage(CloneMessage(first_message_));
155 QueueMessage(CloneMessage(second_message_));
156 DrainMessages(1, &messages);
157 ASSERT_EQ(2u, messages.size());
158 ASSERT_EQ(first_message_.routing_id(), messages[0]->routing_id());
159 ASSERT_EQ(second_message_.routing_id(), messages[1]->routing_id());
160 }
161
162 class NotifiesDeletionMessage : public IPC::Message {
163 public:
164 NotifiesDeletionMessage(bool* deleted, const IPC::Message& other)
165 : IPC::Message(other), deleted_(deleted) {}
166 virtual ~NotifiesDeletionMessage() { *deleted_ = true; }
167
168 private:
169 bool* deleted_;
170 };
171
172 TEST_F(FrameSwapMessageQueueTest, TestDeletesMessage) {
173 bool message_deleted = false;
174 QueueMessage(make_scoped_ptr(new NotifiesDeletionMessage(&message_deleted,
175 first_message_))
176 .PassAs<IPC::Message>());
177 queue_ = NULL;
178 ASSERT_TRUE(message_deleted);
179 }
180
181 TEST_F(FrameSwapMessageQueueTest, TestDeletesMessageQueuedForFrame) {
182 bool message_deleted = false;
183 QueueMessageForFrame(1,
184 make_scoped_ptr(new NotifiesDeletionMessage(
185 &message_deleted, first_message_))
186 .PassAs<IPC::Message>());
187 queue_ = NULL;
188 ASSERT_TRUE(message_deleted);
189 }
190
191 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698