Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Issue 2401623003: Remove ink drop highlight for Ash MD SystemMenuButton (Closed)

Created:
4 years, 2 months ago by tdanderson
Modified:
4 years, 2 months ago
Reviewers:
varkha, mohsen
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ink drop highlight for Ash MD SystemMenuButton Remove the ink drop highlight (hover) effect for the system menu buttons used in Ash material design (--ash-md=experimental) for design review. Also update the base color of the ripple effect to black. BUG=649734 TEST=manual Committed: https://crrev.com/98d754ca04c728e5d23ff9aabf307c3afc7634b1 Cr-Commit-Position: refs/heads/master@{#423632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M ash/common/system/tray/system_menu_button.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tdanderson
Valery, PTAL.
4 years, 2 months ago (2016-10-06 15:28:07 UTC) #2
mohsen
LGTM
4 years, 2 months ago (2016-10-06 18:56:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401623003/1
4 years, 2 months ago (2016-10-06 18:57:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 19:38:14 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 19:41:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98d754ca04c728e5d23ff9aabf307c3afc7634b1
Cr-Commit-Position: refs/heads/master@{#423632}

Powered by Google App Engine
This is Rietveld 408576698