Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2401623002: Fix base::Callback<>::IsCancelled handling on nested base::Callback (Closed)

Created:
4 years, 2 months ago by tzik
Modified:
4 years, 2 months ago
Reviewers:
Yuta Kitamura
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix base::Callback<>::IsCancelled handling on nested base::Callback Previous implementation of IsCancelled doesn't have a specialization for nested OnceCallback. That implies OnceCallback::IsCancelled returns false when it's a nested callback and the inner callback is a cancelled OnceCallback. Committed: https://crrev.com/44adf07a8104da5e1ff35b9f57e30ad050d5f301 Cr-Commit-Position: refs/heads/master@{#423796}

Patch Set 1 #

Patch Set 2 : +test #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M base/bind_internal.h View 1 chunk +7 lines, -3 lines 0 comments Download
M base/bind_unittest.cc View 1 2 3 chunks +24 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
tzik
PTAL
4 years, 2 months ago (2016-10-06 13:59:38 UTC) #8
Yuta Kitamura
LGTM, wow this bug is nasty.
4 years, 2 months ago (2016-10-07 02:34:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401623002/40001
4 years, 2 months ago (2016-10-07 02:36:21 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-07 04:35:14 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 04:37:18 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44adf07a8104da5e1ff35b9f57e30ad050d5f301
Cr-Commit-Position: refs/heads/master@{#423796}

Powered by Google App Engine
This is Rietveld 408576698