Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 24016003: libvpx/ads2gas_apple.pl: prefix comment delimiter '@' with a space for clang integrated assembler. (Closed)

Created:
7 years, 3 months ago by Ami GONE FROM CHROMIUM
Modified:
7 years, 3 months ago
Reviewers:
wwcv, Johann
CC:
chromium-reviews
Visibility:
Public.

Description

libvpx/ads2gas_apple.pl: prefix comment delimiter '@' with a space for clang integrated assembler. BUG=https://code.google.com/p/webrtc/issues/detail?id=2332 R=johannkoenig@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M source/libvpx/build/make/ads2gas_apple.pl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ami GONE FROM CHROMIUM
I'm not sure why this became necessary when last week it wasn't, but it seems ...
7 years, 3 months ago (2013-09-23 17:25:17 UTC) #1
Johann
LGTM What a strange restriction. Do you have the error message?
7 years, 3 months ago (2013-09-23 18:30:39 UTC) #2
Ami GONE FROM CHROMIUM
On 2013/09/23 18:30:39, Johann wrote: > LGTM > > What a strange restriction. Do you ...
7 years, 3 months ago (2013-09-24 16:38:42 UTC) #3
Ami GONE FROM CHROMIUM
7 years, 3 months ago (2013-09-24 16:46:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r225010 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698