Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: build/toolchain/toolchain.gni

Issue 2401573005: Clean up some GN/hermetic build changes. (Closed)
Patch Set: More fixes. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/mac/xcrun.py ('k') | chrome/tools/build/mac/run_verify_order.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Toolchain-related configuration that may be needed outside the context of the 5 # Toolchain-related configuration that may be needed outside the context of the
6 # toolchain() rules themselves. 6 # toolchain() rules themselves.
7 7
8 import("//build/config/chrome_build.gni") 8 import("//build/config/chrome_build.gni")
9 9
10 declare_args() { 10 declare_args() {
(...skipping 29 matching lines...) Expand all
40 # with the build. Used on iOS to ship official builds (as they are built 40 # with the build. Used on iOS to ship official builds (as they are built
41 # with the version of clang shipped with Xcode). 41 # with the version of clang shipped with Xcode).
42 use_xcode_clang = is_ios && is_official_build 42 use_xcode_clang = is_ios && is_official_build
43 43
44 # Use the system install of Xcode for tools like ibtool, libtool, etc. 44 # Use the system install of Xcode for tools like ibtool, libtool, etc.
45 # This does not affect the compiler. When this variable is false, targets will 45 # This does not affect the compiler. When this variable is false, targets will
46 # instead use a hermetic install of Xcode. [The hermetic install can be 46 # instead use a hermetic install of Xcode. [The hermetic install can be
47 # obtained with gclient sync after setting the environment variable 47 # obtained with gclient sync after setting the environment variable
48 # FORCE_MAC_TOOLCHAIN]. 48 # FORCE_MAC_TOOLCHAIN].
49 use_system_xcode = true 49 use_system_xcode = true
50 }
50 51
51 # The path to the hermetic install of Xcode. Only relevant when 52 # The path to the hermetic install of Xcode. Only relevant when
52 # use_system_xcode = false. 53 # use_system_xcode = false.
53 hermetic_xcode_path = 54 hermetic_xcode_path =
54 rebase_path("//build/mac_files/Xcode.app", "", root_build_dir) 55 rebase_path("//build/mac_files/Xcode.app", "", root_build_dir)
55 }
56 56
57 declare_args() { 57 declare_args() {
58 if (is_clang) { 58 if (is_clang) {
59 # Clang compiler version. Clang files are placed at version-dependent paths. 59 # Clang compiler version. Clang files are placed at version-dependent paths.
60 clang_version = "4.0.0" 60 clang_version = "4.0.0"
61 } 61 }
62 } 62 }
63 63
64 # Check target_os here instead of is_ios as this file is loaded for secondary 64 # Check target_os here instead of is_ios as this file is loaded for secondary
65 # toolchain (host toolchain in particular) but the argument is the same for 65 # toolchain (host toolchain in particular) but the argument is the same for
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 _tool_wrapper_path = 113 _tool_wrapper_path =
114 rebase_path("//build/toolchain/win/tool_wrapper.py", root_build_dir) 114 rebase_path("//build/toolchain/win/tool_wrapper.py", root_build_dir)
115 115
116 stamp_command = "$python_path $_tool_wrapper_path stamp {{output}}" 116 stamp_command = "$python_path $_tool_wrapper_path stamp {{output}}"
117 copy_command = 117 copy_command =
118 "$python_path $_tool_wrapper_path recursive-mirror {{source}} {{output}}" 118 "$python_path $_tool_wrapper_path recursive-mirror {{source}} {{output}}"
119 } else { 119 } else {
120 stamp_command = "touch {{output}}" 120 stamp_command = "touch {{output}}"
121 copy_command = "ln -f {{source}} {{output}} 2>/dev/null || (rm -rf {{output}} && cp -af {{source}} {{output}})" 121 copy_command = "ln -f {{source}} {{output}} 2>/dev/null || (rm -rf {{output}} && cp -af {{source}} {{output}})"
122 } 122 }
OLDNEW
« no previous file with comments | « build/config/mac/xcrun.py ('k') | chrome/tools/build/mac/run_verify_order.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698