Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2401573005: Clean up some GN/hermetic build changes. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Nico, sdefresne
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some GN/hermetic build changes. No functional changes, just style. BUG= Committed: https://crrev.com/55e37ffdfc5d1aa4f47ae7e9bc0c8bc58ba23af5 Cr-Commit-Position: refs/heads/master@{#424199}

Patch Set 1 #

Patch Set 2 : More fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build/config/mac/compile_xib.py View 1 chunk +1 line, -1 line 0 comments Download
M build/config/mac/xcrun.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/toolchain.gni View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/tools/build/mac/run_verify_order.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
erikchen
sdefresne: Please review.
4 years, 2 months ago (2016-10-07 23:26:07 UTC) #2
sdefresne
On 2016/10/07 23:26:07, erikchen wrote: > sdefresne: Please review. Looks good, but there were some ...
4 years, 2 months ago (2016-10-10 02:28:21 UTC) #3
erikchen
thakis: Please review.
4 years, 2 months ago (2016-10-10 17:47:05 UTC) #8
Nico
lgtm
4 years, 2 months ago (2016-10-10 17:50:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401573005/20001
4 years, 2 months ago (2016-10-10 17:51:21 UTC) #11
sdefresne
lgtm
4 years, 2 months ago (2016-10-10 17:57:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 18:44:45 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 18:46:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55e37ffdfc5d1aa4f47ae7e9bc0c8bc58ba23af5
Cr-Commit-Position: refs/heads/master@{#424199}

Powered by Google App Engine
This is Rietveld 408576698