Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Issue 2401573004: String.codeUnitAt has no side-effects (Closed)

Created:
4 years, 2 months ago by sra1
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

String.codeUnitAt has no side-effects BUG= Committed: https://github.com/dart-lang/sdk/commit/808c35cbeeff35b20f3d47e90a457e7324409659

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix dispatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -51 lines) Patch
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 2 chunks +38 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
4 years, 2 months ago (2016-10-07 21:52:05 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2401573004/diff/20001/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart File pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart (right): https://codereview.chromium.org/2401573004/diff/20001/pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart#newcode50 pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart:50: if (name == 'unary-') return const UnaryNegateSpecializer(); yay, much ...
4 years, 2 months ago (2016-10-07 22:35:36 UTC) #5
sra1
4 years, 2 months ago (2016-10-08 19:39:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
808c35cbeeff35b20f3d47e90a457e7324409659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698