Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 240153003: Remove the HTMLSourceElement.media IDL attribute (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
CC:
blink-reviews, arv+blink, philipj_slow, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
D LayoutTests/media/source-media-deprecated.html View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/media/source-media-deprecated-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSourceElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLSourceElement.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
6 years, 8 months ago (2014-04-18 10:00:09 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-18 16:31:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/240153003/20001
6 years, 8 months ago (2014-04-18 16:32:07 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 17:02:39 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-18 17:02:39 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-04-18 20:23:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/240153003/20001
6 years, 8 months ago (2014-04-18 20:23:37 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 20:31:31 UTC) #8
Message was sent while issue was closed.
Change committed as 171970

Powered by Google App Engine
This is Rietveld 408576698