third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp - Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElementException.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp b/third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp

index 0bd5a314363ede37ab240025ab1fc7f1a7ecd4fc..c9e6ff6521eb4f784478de1dc35c9bcf4aedc48f 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp

@@ -66,7 +66,7 @@ void AttachedDetachedInvocation::dispatch(Element* element) {

callbacks()->detached(element);

break;

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

}

@@ -130,7 +130,7 @@ V0CustomElementCallbackInvocation::createInvocation(

case V0CustomElementLifecycleCallbacks::DetachedCallback:

return new AttachedDetachedInvocation(callbacks, which);

default:

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return nullptr;

}