third_party/WebKit/Source/core/dom/IconURL.cpp - Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IconURL.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IconURL.cpp

diff --git a/third_party/WebKit/Source/core/dom/IconURL.cpp b/third_party/WebKit/Source/core/dom/IconURL.cpp

index 3e0bb1698b154d052c01c01126a577a02d256f9c..88ac9b4f999afcab91dd850422eb7095557f9d90 100644

--- a/third_party/WebKit/Source/core/dom/IconURL.cpp

+++ b/third_party/WebKit/Source/core/dom/IconURL.cpp

@@ -36,7 +36,7 @@ IconURL IconURL::defaultFavicon(const KURL& documentURL) {

DCHECK(documentURL.protocolIsInHTTPFamily());

KURL url;

bool couldSetProtocol = url.setProtocol(documentURL.protocol());

- ASSERT_UNUSED(couldSetProtocol, couldSetProtocol);

+ DCHECK(couldSetProtocol);

url.setHost(documentURL.host());

if (documentURL.hasPort())

url.setPort(documentURL.port());