Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2401513003: Worker: Clean up InProcessWorkerBase (Closed)

Created:
4 years, 2 months ago by nhiroki
Modified:
4 years, 2 months ago
Reviewers:
falken
CC:
chromium-reviews, shimazu+worker_chromium.org, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Clean up InProcessWorkerBase This CL removes unnecessary header inclusions and refactors parameter passing for startWorkerGlobalScope. This should not change behavior. BUG=n/a Committed: https://crrev.com/5a13edcd53a30b9811d879053e229cc07e40b6ed Cr-Commit-Position: refs/heads/master@{#423777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -40 lines) Patch
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.h View 3 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 3 chunks +7 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
nhiroki
PTAL, thanks!
4 years, 2 months ago (2016-10-06 06:58:45 UTC) #5
falken
nice cleanup. lgtm
4 years, 2 months ago (2016-10-07 01:27:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401513003/1
4 years, 2 months ago (2016-10-07 01:39:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 01:46:16 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 01:47:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a13edcd53a30b9811d879053e229cc07e40b6ed
Cr-Commit-Position: refs/heads/master@{#423777}

Powered by Google App Engine
This is Rietveld 408576698