Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2401463004: Issue 27515. Report DUPLICATE_PAR when the same library contains two part directives with the same … (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 27515. Report DUPLICATE_PART when the same library contains two part directives with the same URI. R=brianwilkerson@google.com, paulberry@google.com BUG= https://github.com/dart-lang/sdk/issues/27515 Committed: https://github.com/dart-lang/sdk/commit/26cc95d8b4ad09971cef55c196cc632de8f97be0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M pkg/analyzer/lib/src/error/codes.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +13 lines, -0 lines 1 comment Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
4 years, 2 months ago (2016-10-06 18:14:18 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2401463004/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/2401463004/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode1537 pkg/analyzer/lib/src/task/dart.dart:1537: // Validate that the part contains a part-of ...
4 years, 2 months ago (2016-10-06 18:18:23 UTC) #3
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-06 18:23:26 UTC) #4
scheglov
4 years, 2 months ago (2016-10-06 18:28:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26cc95d8b4ad09971cef55c196cc632de8f97be0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698