Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 2401443002: Fix nested URL blocking needs with PlzNavigate. (Closed)

Created:
4 years, 2 months ago by jam
Modified:
4 years, 2 months ago
Reviewers:
alexmos, dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nested URL blocking needs with PlzNavigate. Navigations from extension processes for chrome-extension URLs will get a response with a blob:chrome-extension scheme when using PlzNavigate. So store the fact that this is for an extension process with the navigate data so that we an refer to it later on the IO thread. This fixes ProcessManagerBrowserTest.NestedURLNavigationsToExtensionAllowed ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked BUG=504347, 647712

Patch Set 1 #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M chrome/browser/net/chrome_extensions_network_delegate.cc View 3 chunks +9 lines, -3 lines 1 comment Download
M chrome/browser/renderer_host/chrome_navigation_ui_data.cc View 1 chunk +20 lines, -2 lines 6 comments Download
M content/renderer/render_widget.cc View 2 chunks +7 lines, -2 lines 6 comments Download
M extensions/browser/extension_navigation_ui_data.h View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/browser/extension_navigation_ui_data.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (20 generated)
jam
dcheng: content/renderer (since this is code you added in https://codereview.chromium.org/1303773002) alexmos: the rest
4 years, 2 months ago (2016-10-05 22:48:13 UTC) #16
dcheng
https://codereview.chromium.org/2401443002/diff/60001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/2401443002/diff/60001/content/renderer/render_widget.cc#newcode330 content/renderer/render_widget.cc:330: // With PlzNavigate, the widget could already be created ...
4 years, 2 months ago (2016-10-06 02:34:00 UTC) #22
jam
https://codereview.chromium.org/2401443002/diff/60001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/2401443002/diff/60001/content/renderer/render_widget.cc#newcode330 content/renderer/render_widget.cc:330: // With PlzNavigate, the widget could already be created ...
4 years, 2 months ago (2016-10-06 04:33:48 UTC) #23
jam
https://codereview.chromium.org/2401443002/diff/60001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/2401443002/diff/60001/content/renderer/render_widget.cc#newcode330 content/renderer/render_widget.cc:330: // With PlzNavigate, the widget could already be created ...
4 years, 2 months ago (2016-10-06 15:09:19 UTC) #24
alexmos
https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/net/chrome_extensions_network_delegate.cc File chrome/browser/net/chrome_extensions_network_delegate.cc (right): https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/net/chrome_extensions_network_delegate.cc#newcode197 chrome/browser/net/chrome_extensions_network_delegate.cc:197: // https://crbug.com/652077. nit: maybe expand this comment to mention ...
4 years, 2 months ago (2016-10-06 22:37:28 UTC) #25
jam
https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc File chrome/browser/renderer_host/chrome_navigation_ui_data.cc (right): https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc#newcode36 chrome/browser/renderer_host/chrome_navigation_ui_data.cc:36: web_contents->GetSiteInstance()->GetSiteURL()); On 2016/10/06 22:37:28, alexmos wrote: > Wouldn't going ...
4 years, 2 months ago (2016-10-06 22:54:31 UTC) #26
alexmos
https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc File chrome/browser/renderer_host/chrome_navigation_ui_data.cc (right): https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc#newcode36 chrome/browser/renderer_host/chrome_navigation_ui_data.cc:36: web_contents->GetSiteInstance()->GetSiteURL()); On 2016/10/06 22:54:31, jam wrote: > On 2016/10/06 ...
4 years, 2 months ago (2016-10-07 01:47:47 UTC) #27
jam
https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc File chrome/browser/renderer_host/chrome_navigation_ui_data.cc (right): https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc#newcode36 chrome/browser/renderer_host/chrome_navigation_ui_data.cc:36: web_contents->GetSiteInstance()->GetSiteURL()); On 2016/10/07 01:47:47, alexmos wrote: > On 2016/10/06 ...
4 years, 2 months ago (2016-10-10 15:36:50 UTC) #28
alexmos
https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc File chrome/browser/renderer_host/chrome_navigation_ui_data.cc (right): https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc#newcode36 chrome/browser/renderer_host/chrome_navigation_ui_data.cc:36: web_contents->GetSiteInstance()->GetSiteURL()); On 2016/10/10 15:36:50, jam wrote: > On 2016/10/07 ...
4 years, 2 months ago (2016-10-10 17:04:21 UTC) #29
jam
https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc File chrome/browser/renderer_host/chrome_navigation_ui_data.cc (right): https://codereview.chromium.org/2401443002/diff/60001/chrome/browser/renderer_host/chrome_navigation_ui_data.cc#newcode36 chrome/browser/renderer_host/chrome_navigation_ui_data.cc:36: web_contents->GetSiteInstance()->GetSiteURL()); On 2016/10/10 17:04:21, alexmos wrote: > On 2016/10/10 ...
4 years, 2 months ago (2016-10-10 21:48:15 UTC) #30
jam
4 years, 2 months ago (2016-10-11 19:09:40 UTC) #31
Message was sent while issue was closed.
closing this out in favor of https://codereview.chromium.org/2411693003/

Powered by Google App Engine
This is Rietveld 408576698