Issue 2401423005: Land all the fixes from 5609f39c but don't enable assert

Issue 2401423005: Land all the fixes from 5609f39c but don't enable assert (Closed)

Created:
4 years, 2 months ago by Tom Sepez

Modified:
4 years, 2 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Land all the fixes from 5609f39c but don't enable assert Split this off so that we don't keep losing this when the assert is reverted again. Committed: https://pdfium.googlesource.com/pdfium/+/836f7d5d23b0951c8be86ccca54ebad43179febe

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -33 lines)			Patch
M	core/fpdfapi/parser/cpdf_array.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/fpdfapi/parser/cpdf_dictionary.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/fpdfapi/parser/cpdf_object_unittest.cpp	View	6 chunks	+25 lines, -7 lines	0 comments	Download
M	core/fpdfapi/parser/cpdf_parser.cpp	View	4 chunks	+14 lines, -23 lines	0 comments	Download
M	core/fpdfapi/parser/cpdf_stream.cpp	View	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401423005/1

4 years, 2 months ago (2016-10-10 21:18:49 UTC) #5

commit-bot: I haz the power

4 years, 2 months ago (2016-10-10 21:31:08 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/836f7d5d23b0951c8be86ccca54ebad43179...