Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 2401423004: Fix new tab button (broken when removing pre-MD code). (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix new tab button (broken when removing pre-MD code). BUG=653905 Committed: https://crrev.com/434b901825d725fb21e7a98ab2f27b128c504159 Cr-Commit-Position: refs/heads/master@{#424230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Evan Stade
4 years, 2 months ago (2016-10-10 19:03:13 UTC) #2
Peter Kasting
LGTM
4 years, 2 months ago (2016-10-10 19:35:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401423004/1
4 years, 2 months ago (2016-10-10 20:34:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 20:41:14 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 20:43:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/434b901825d725fb21e7a98ab2f27b128c504159
Cr-Commit-Position: refs/heads/master@{#424230}

Powered by Google App Engine
This is Rietveld 408576698