chrome/browser/extensions/api/braille_display_private/mock_braille_controller.cc - Issue 2401393003: Add multiline braille support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/mock_braille_controller.cc

Issue 2401393003: Add multiline braille support. (Closed)

Patch Set: Addressed comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc ('K') | « chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc ('k') | chrome/browser/extensions/api/braille_display_private/stub_braille_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/mock_braille_controller.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/mock_braille_controller.cc b/chrome/browser/extensions/api/braille_display_private/mock_braille_controller.cc

index 0bfd5f9c0dd1a1d91c468432cca31764e4ba0974..65efa74698508372c82bdf6f1596b3fa15395321 100644

--- a/chrome/browser/extensions/api/braille_display_private/mock_braille_controller.cc

+++ b/chrome/browser/extensions/api/braille_display_private/mock_braille_controller.cc

@@ -14,8 +14,10 @@ MockBrailleController::MockBrailleController()

std::unique_ptr<DisplayState> MockBrailleController::GetDisplayState() {

std::unique_ptr<DisplayState> state(new DisplayState());

state->available = available_;

- if (available_)

- state->text_cell_count.reset(new int(18));

+ if (available_){

Devlin 2016/11/02 15:10:30 nit: need space after end paren here

ultimatedbz 2016/11/03 19:28:54 Thanks!

+ state->text_column_count.reset(new int(18));

+ state->text_row_count.reset(new int(18));

+ }

return state;

}