Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3936)

Unified Diff: chrome/common/extensions/api/braille_display_private.idl

Issue 2401393003: Add multiline braille support. (Closed)
Patch Set: Addressed review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/braille_display_private.idl
diff --git a/chrome/common/extensions/api/braille_display_private.idl b/chrome/common/extensions/api/braille_display_private.idl
index 0c7a3e69dc00fdbf5cb99c85ff770776dcfcb7f6..7812d7ecf5936258ed192a6e203fb4db891eb5fe 100644
--- a/chrome/common/extensions/api/braille_display_private.idl
+++ b/chrome/common/extensions/api/braille_display_private.idl
@@ -51,8 +51,10 @@ namespace brailleDisplayPrivate {
dictionary DisplayState {
// Whether a braille display is currently available.
boolean available;
- // Number of braille cells on the currently connected display.
- long? textCellCount;
+ // Number of rows of braille cells on the currently connected display.
+ long? textRowCount;
+ // Number of columns of braille cells on the currently connected display.
+ long? textColumnCount;
};
callback DisplayStateCallback = void(DisplayState result);
@@ -67,7 +69,7 @@ namespace brailleDisplayPrivate {
// dot 1 and so on until bit 7 which corresponds to dot 8. If the number
// of bytes in the buffer is not equal to the display size, the buffer
// will either be clipped or padded with blank cells on the right.
- static void writeDots(ArrayBuffer cells);
+ static void writeDots(ArrayBuffer cells, long columns, long rows);
Devlin 2016/10/18 23:01:29 document new params columns and rows?
ultimatedbz 2016/10/20 18:27:45 Done.
};
interface Events {

Powered by Google App Engine
This is Rietveld 408576698