chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h - Issue 2401393003: Add multiline braille support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

Issue 2401393003: Add multiline braille support. (Closed)

Patch Set: more tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/braille_controller.h ('k') | chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h b/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

index aafa57d7b468bb230ebe7c8dc941159f62189187..63962e844f55e9d28d24f1ade39fcec41b399bf8 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

+++ b/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h

@@ -25,7 +25,9 @@ class BrailleControllerImpl : public BrailleController {

public:

static BrailleControllerImpl* GetInstance();

std::unique_ptr<DisplayState> GetDisplayState() override;

- void WriteDots(const std::vector<char>& cells) override;

+ void WriteDots(const std::vector<char>& cells,

+ unsigned int cols,

+ unsigned int rows) override;

void AddObserver(BrailleObserver* observer) override;

void RemoveObserver(BrailleObserver* observer) override;