chrome/browser/extensions/api/braille_display_private/braille_controller.h - Issue 2401393003: Add multiline braille support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_controller.h

Issue 2401393003: Add multiline braille support. (Closed)

Patch Set: Got braille cells to show up on braille display Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h » ('j') | chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_controller.h

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_controller.h b/chrome/browser/extensions/api/braille_display_private/braille_controller.h

index 73ec3e6b5fa496e72594e92d18b52fd9979760f7..5b575d2a32e5e2e04faff2d5dccb83d063fc521d 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_controller.h

+++ b/chrome/browser/extensions/api/braille_display_private/braille_controller.h

@@ -24,7 +24,9 @@ class BrailleController {

static BrailleController* GetInstance();

virtual std::unique_ptr<DisplayState> GetDisplayState() = 0;

- virtual void WriteDots(const std::vector<char>& cells) = 0;

+ virtual void WriteDots(const std::vector<char>& cells,

+ unsigned int cols,

+ unsigned int rows) = 0;

virtual void AddObserver(BrailleObserver* observer) = 0;

virtual void RemoveObserver(BrailleObserver* observer) = 0;