chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js - Issue 2401393003: Add multiline braille support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

Issue 2401393003: Add multiline braille support. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc ('K') | « chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc ('k') | chrome/browser/resources/chromeos/chromevox/host/chrome/externs.js » ('j') | chrome/browser/resources/chromeos/chromevox/host/chrome/externs.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js b/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

index 5f2039a212dfe04518e72764919125341fd32e40..20373131460c253aa21c7e69c1efdb24a2911a21 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

@@ -193,7 +193,7 @@ cvox.BrailleDisplayManager.prototype.refresh_ = function() {

var viewPort = this.panStrategy_.viewPort;

var buf = this.displayedContent_.slice(viewPort.start, viewPort.end);

if (this.realDisplayState_.available) {

- chrome.brailleDisplayPrivate.writeDots(buf);

+ chrome.brailleDisplayPrivate.writeDots(buf, 1, buf.byteLength);

dmazzoni 2016/10/11 17:15:39 Ideally you can change all of the code inside Chro

}

if (cvox.BrailleCaptionsBackground.isEnabled()) {

var start = this.brailleToTextPosition_(viewPort.start);