Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: chrome/browser/extensions/api/braille_display_private/brlapi_connection.h

Issue 2401393003: Add multiline braille support. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/braille_display_private/brlapi_connection.h
diff --git a/chrome/browser/extensions/api/braille_display_private/brlapi_connection.h b/chrome/browser/extensions/api/braille_display_private/brlapi_connection.h
index f1cba434098d37b7267a65725e33bfde7c0cf905..bf6cc333fc6e8a6b98a70b4c05f59df7beb63d70 100644
--- a/chrome/browser/extensions/api/braille_display_private/brlapi_connection.h
+++ b/chrome/browser/extensions/api/braille_display_private/brlapi_connection.h
@@ -8,6 +8,7 @@
#include <stddef.h>
#include <memory>
+#include <vector>
#include "base/callback_forward.h"
#include "base/macros.h"
@@ -53,11 +54,13 @@ class BrlapiConnection {
// Gets the total size of the display, which may be 0 if no display is
dmazzoni 2016/10/11 17:15:39 Update this comment
ultimatedbz 2016/10/16 01:12:39 Done.
// present, returning true on success. Note that this is cached in the
// brlapi client so it is cheap.
- virtual bool GetDisplaySize(size_t* size) = 0;
+ virtual bool GetDisplaySize(unsigned int* rows, unsigned int* columns) = 0;
// Sends the specified cells to the display. The array size must
dmazzoni 2016/10/11 17:15:39 Update the comment
ultimatedbz 2016/10/16 01:12:39 Done.
// be equal to what GetDisplaySize() last returned for this connection.
- virtual bool WriteDots(const unsigned char* cells) = 0;
+// virtual bool WriteDots(const std::vector<unsigned char> cells) = 0;
dmazzoni 2016/10/11 17:15:39 Delete the old commented-out line
ultimatedbz 2016/10/16 01:12:39 Done.
+ virtual bool WriteDots(
+ const std::vector<std::vector<unsigned char>> cells) = 0;
// Reads the next keyboard command, returning true on success.
// Returns < 0 on error, 0 if no more keys are pending and > 0

Powered by Google App Engine
This is Rietveld 408576698