third_party/WebKit/Source/core/editing/FrameCaret.h - Issue 2401363003: Use anchor node, rather than current selected node, to check editability.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameCaret.h

Issue 2401363003: Use anchor node, rather than current selected node, to check editability. (Closed)

Patch Set: Feedback. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection-after-delete-expected.txt ('k') | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('j') | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 73 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
84	84

85 bool shouldBlinkCaret() const;	85 bool shouldBlinkCaret() const;

86 void caretBlinkTimerFired(TimerBase*);	86 void caretBlinkTimerFired(TimerBase*);

87 bool caretPositionIsValidForDocument(const Document&) const;	87 bool caretPositionIsValidForDocument(const Document&) const;

88	88

89 const Member<const SelectionEditor> m_selectionEditor;	89 const Member<const SelectionEditor> m_selectionEditor;

90 const Member<LocalFrame> m_frame;	90 const Member<LocalFrame> m_frame;

91 // The last node which painted the caret. Retained for clearing the old	91 // The last node which painted the caret. Retained for clearing the old

92 // caret when it moves.	92 // caret when it moves.

93 Member<Node> m_previousCaretNode;	93 Member<Node> m_previousCaretNode;

	94 Member<Node> m_previousCaretAnchorNode;

94 LayoutRect m_previousCaretRect;	95 LayoutRect m_previousCaretRect;

95 CaretVisibility m_caretVisibility;	96 CaretVisibility m_caretVisibility;

96 CaretVisibility m_previousCaretVisibility;	97 CaretVisibility m_previousCaretVisibility;

97 Timer<FrameCaret> m_caretBlinkTimer;	98 Timer<FrameCaret> m_caretBlinkTimer;

98 bool m_caretRectDirty : 1;	99 bool m_caretRectDirty : 1;

99 bool m_shouldPaintCaret : 1;	100 bool m_shouldPaintCaret : 1;

100 bool m_isCaretBlinkingSuspended : 1;	101 bool m_isCaretBlinkingSuspended : 1;

101 bool m_shouldShowBlockCursor : 1;	102 bool m_shouldShowBlockCursor : 1;

102 };	103 };

103	104

104 } // namespace blink	105 } // namespace blink

105	106

106 #endif // FrameCaret_h	107 #endif // FrameCaret_h

OLD	NEW