Tracking filter mutation via SVGElementProxy

third_party/WebKit/Source/core/svg/SVGResourceClient.h

Index: third_party/WebKit/Source/core/svg/SVGResourceClient.h
diff --git a/third_party/WebKit/Source/core/svg/SVGResourceClient.h b/third_party/WebKit/Source/core/svg/SVGResourceClient.h
index 58b4f5378f9c9a8ee6f2412c75245c6a397f413d..dd2182802ab48e92e92bbe997b5f9f482ee62471 100644
--- a/third_party/WebKit/Source/core/svg/SVGResourceClient.h
+++ b/third_party/WebKit/Source/core/svg/SVGResourceClient.h
@@ -6,36 +6,23 @@
 #define SVGResourceClient_h
 
 #include "core/CoreExport.h"
-#include "core/fetch/DocumentResource.h"
-#include "core/svg/SVGFilterElement.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
-class Document;
-class FilterOperations;
-
-class CORE_EXPORT SVGResourceClient : public DocumentResourceClient {
-  USING_PRE_FINALIZER(SVGResourceClient, clearFilterReferences);
+class SVGElementProxy;
 
+class CORE_EXPORT SVGResourceClient : public GarbageCollectedMixin {
  public:
-  SVGResourceClient();
-  ~SVGResourceClient() override;
-  void addFilterReferences(const FilterOperations&, const Document&);
-  void clearFilterReferences();
-
-  virtual void filterNeedsInvalidation() = 0;
-
-  void filterWillBeDestroyed(SVGFilterElement*);
+  virtual ~SVGResourceClient() {}
 
-  void notifyFinished(Resource*) override;
-  String debugName() const override { return "SVGResourceClient"; }
+  virtual void resourceContentChanged(SVGElementProxy*) = 0;
+  virtual void resourceReferenceChanged(SVGElementProxy*) = 0;

[pdr., 2016/10/20 03:11:05]

Are the SVGElementProxy* arguments needed? Would it be safe to use them since
the proxy could be freed when this is called?

[fs, 2016/10/20 11:28:00]

I guess they aren't strictly needed (yet. Will be if/when a client is registered
- and cares about - multiple proxies.)

I can drop them for now.

They are safe because the reference is GCd and on the stack.

 
-  DECLARE_TRACE();
+  DEFINE_INLINE_VIRTUAL_TRACE() {}
 
- private:
-  HeapHashSet<WeakMember<SVGFilterElement>> m_internalFilterReferences;
-  HeapVector<Member<DocumentResource>> m_externalFilterReferences;
+ protected:
+  SVGResourceClient() {}
 };
 
 }  // namespace blink