Add a blink InterfaceRegistry.

Add a blink InterfaceRegistry.

Currently, blink can use an InterfaceProvider to initiate communication
with a browser-implemented mojo interface. However, there is no way for
blink to directly provide mojo interfaces to the browser; instead there
must be some code in //content/renderer or //chrome/renderer to bridge
between the InterfaceRegistry there and blink. This CL adds a per-frame
InterfaceRegistry in blink that allows the browser to directly request
interfaces from blink.

BUG=593607
Committed: https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184
Cr-Commit-Position: refs/heads/master@{#425250}

[Sam McNally, 2016-10-10 03:26:42]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 03:26:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-10 03:36:06]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 03:36:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-10 03:36:34]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-10-10 04:29:10]

sammc@chromium.org changed reviewers:
+ esprehn@chromium.org

[commit-bot: I haz the power, 2016-10-10 05:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 05:13:34]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-13 22:26:14]

ping

[esprehn, 2016-10-13 22:31:55]

https://codereview.chromium.org/2401333002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/InterfaceRegistry.h (right):

https://codereview.chromium.org/2401333002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/InterfaceRegistry.h:19: using
InterfaceFactory = WebCallbacks<mojo::ScopedMessagePipeHandle, void>;
Can we use Function and Closure directly instead?

https://codereview.chromium.org/2401333002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/InterfaceRegistry.h:35: new
CallbackImpl<Interface>(std::move(factory))));
convertToBaseCallback ?

https://codereview.chromium.org/2401333002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/InterfaceRegistry.h:51: void onError() {}
Yeah you definitely want to use convertToBaseCallback and base::Callback instead
:)

[Sam McNally, 2016-10-13 22:46:12]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 22:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-10-13 22:46:50]

Patchset #2 (id:40001) has been deleted

[Sam McNally, 2016-10-13 22:57:03]

Patchset #2 (id:60001) has been deleted

[Sam McNally, 2016-10-13 22:58:06]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 22:58:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 00:34:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 00:34:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Sam McNally, 2016-10-14 00:35:57]

https://codereview.chromium.org/2401333002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/InterfaceRegistry.h (right):

https://codereview.chromium.org/2401333002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/InterfaceRegistry.h:19: using
InterfaceFactory = WebCallbacks<mojo::ScopedMessagePipeHandle, void>;
On 2016/10/13 22:31:55, esprehn wrote:
> Can we use Function and Closure directly instead?

Done.

https://codereview.chromium.org/2401333002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/InterfaceRegistry.h:35: new
CallbackImpl<Interface>(std::move(factory))));
On 2016/10/13 22:31:55, esprehn wrote:
> convertToBaseCallback ?

Done.

https://codereview.chromium.org/2401333002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/InterfaceRegistry.h:51: void onError() {}
On 2016/10/13 22:31:55, esprehn wrote:
> Yeah you definitely want to use convertToBaseCallback and base::Callback
instead
> :)

Done.

[esprehn, 2016-10-14 02:20:46]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, reillyg@chromium.org

[esprehn, 2016-10-14 02:20:47]

lgtm, this is fine to land, but reillyg@ and haraken@ might have feedback. I'd
say go for it and we can fix any feedback from then in a follow up? :)

[haraken, 2016-10-14 02:28:16]

This looks nice to me. LGTM

[Sam McNally, 2016-10-14 02:35:41]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-10-14 02:35:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 04:17:19]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-10-14 04:19:50]

Description was changed from

==========
Add a blink InterfaceRegistry.

Currently, blink can use an InterfaceProvider to initiate communication
with a browser-implemented mojo interface. However, there is no way for
blink to directly provide mojo interfaces to the browser; instead there
must be some code in //content/renderer or //chrome/renderer to bridge
between the InterfaceRegistry there and blink. This CL adds a per-frame
InterfaceRegistry in blink that allows the browser to directly request
interfaces from blink.

BUG=593607
==========

to

==========
Add a blink InterfaceRegistry.

Currently, blink can use an InterfaceProvider to initiate communication
with a browser-implemented mojo interface. However, there is no way for
blink to directly provide mojo interfaces to the browser; instead there
must be some code in //content/renderer or //chrome/renderer to bridge
between the InterfaceRegistry there and blink. This CL adds a per-frame
InterfaceRegistry in blink that allows the browser to directly request
interfaces from blink.

BUG=593607

Committed: https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184
Cr-Commit-Position: refs/heads/master@{#425250}
==========

[commit-bot: I haz the power, 2016-10-14 04:19:51]

Patchset 2 (id:??) landed as
https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184
Cr-Commit-Position: refs/heads/master@{#425250}

[Reilly Grant (use Gerrit), 2016-10-14 21:56:08]

lgtm