mojo/embedder/embedder.cc - Issue 240133005: Mojo: Make some attempts towards fixing remote message pipe closure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/embedder/embedder.cc

Issue 240133005: Mojo: Make some attempts towards fixing remote message pipe closure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/embedder/embedder.cc

diff --git a/mojo/embedder/embedder.cc b/mojo/embedder/embedder.cc

index 7698160336dc9d710a19543e9310176c70e02a5c..e8c6e8e53b3a84333c0fdcf41e54aa648fb847b9 100644

--- a/mojo/embedder/embedder.cc

+++ b/mojo/embedder/embedder.cc

@@ -44,6 +44,8 @@ static void CreateChannelOnIOThread(

// Attach the message pipe endpoint.

system::MessageInTransit::EndpointId endpoint_id =

channel_info->channel->AttachMessagePipeEndpoint(message_pipe, 1);

+ // We shouldn't get |kInvalidEndpointId| here -- since |CreateChannel()| is

+ // responsible for the local endpoint, and won't close it.

DCHECK_EQ(endpoint_id, system::Channel::kBootstrapEndpointId);

success = channel_info->channel->RunMessagePipeEndpoint(

system::Channel::kBootstrapEndpointId,

« no previous file with comments | « no previous file | mojo/system/channel.h » ('j') | mojo/system/channel.cc » ('J')