ElementVisibilityObserver: use ExecutionContext's document.

ElementVisibilityObserver: use ExecutionContext's document.

The IntersectionObserver code assumes that the document passed as root
always has a frame but an Element's owner document might not. Using the
ExecutionContext's document in ElementVisibilityObserver solves issues
by making the internal API behaviour closer to the external one.

BUG=654082
Committed: https://crrev.com/a6916ff2267d97e2e0db212348d4229097d37064
Cr-Commit-Position: refs/heads/master@{#425099}

[mlamouri (slow - plz ping), 2016-10-09 22:06:02]

mlamouri@chromium.org changed reviewers:
+ esprehn@chromium.org

[mlamouri (slow - plz ping), 2016-10-09 22:06:07]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-09 22:06:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-09 23:28:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-09 23:28:40]

Dry run: This issue passed the CQ dry run.

[estark, 2016-10-10 17:37:51]

Description was changed from

==========
ElementVisibilityObserver: use ExecutionContext's document.

The IntersectionObserver code assumes that the document passed as root
always has a frame but an Element's owner document might not. Using the
ExecutionContext's document in ElementVisibilityObserver solves issues
by making the internal API behaviour closer to the external one.

BUG=654082
==========

to

==========
ElementVisibilityObserver: use ExecutionContext's document.

The IntersectionObserver code assumes that the document passed as root
always has a frame but an Element's owner document might not. Using the
ExecutionContext's document in ElementVisibilityObserver solves issues
by making the internal API behaviour closer to the external one.

BUG=654082
==========

[mlamouri (slow - plz ping), 2016-10-11 19:51:45]

Review ping. Let me know if you want me to send this to someone else :)

[esprehn, 2016-10-11 22:06:45]

lgtm w/ nits

https://codereview.chromium.org/2401303002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp (right):

https://codereview.chromium.org/2401303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp:16: bool
isInRemoteFrame(Document* document) {
reference then you don't need the DCHECK below?

https://codereview.chromium.org/2401303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp:35: Document*
document = toDocument(context);
Document& document = toDocument(*context);

[mlamouri (slow - plz ping), 2016-10-11 23:22:09]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-10-11 23:22:09]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2401303002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-10-11 23:22:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 23:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 23:35:10]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[mlamouri (slow - plz ping), 2016-10-13 17:04:41]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:04:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 18:33:54]

Description was changed from

==========
ElementVisibilityObserver: use ExecutionContext's document.

The IntersectionObserver code assumes that the document passed as root
always has a frame but an Element's owner document might not. Using the
ExecutionContext's document in ElementVisibilityObserver solves issues
by making the internal API behaviour closer to the external one.

BUG=654082
==========

to

==========
ElementVisibilityObserver: use ExecutionContext's document.

The IntersectionObserver code assumes that the document passed as root
always has a frame but an Element's owner document might not. Using the
ExecutionContext's document in ElementVisibilityObserver solves issues
by making the internal API behaviour closer to the external one.

BUG=654082
==========

[commit-bot: I haz the power, 2016-10-13 18:33:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 18:35:50]

Description was changed from

==========
ElementVisibilityObserver: use ExecutionContext's document.

The IntersectionObserver code assumes that the document passed as root
always has a frame but an Element's owner document might not. Using the
ExecutionContext's document in ElementVisibilityObserver solves issues
by making the internal API behaviour closer to the external one.

BUG=654082
==========

to

==========
ElementVisibilityObserver: use ExecutionContext's document.

The IntersectionObserver code assumes that the document passed as root
always has a frame but an Element's owner document might not. Using the
ExecutionContext's document in ElementVisibilityObserver solves issues
by making the internal API behaviour closer to the external one.

BUG=654082

Committed: https://crrev.com/a6916ff2267d97e2e0db212348d4229097d37064
Cr-Commit-Position: refs/heads/master@{#425099}
==========

[commit-bot: I haz the power, 2016-10-13 18:35:51]

Patchset 2 (id:??) landed as
https://crrev.com/a6916ff2267d97e2e0db212348d4229097d37064
Cr-Commit-Position: refs/heads/master@{#425099}