src/gpu/gl/GrGpuGL.cpp - Issue 240123002: Double assignment in GrGpuGL::configToGLFormats()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGpuGL.cpp

Issue 240123002: Double assignment in GrGpuGL::configToGLFormats() (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/GrGpuGL.cpp

diff --git a/src/gpu/gl/GrGpuGL.cpp b/src/gpu/gl/GrGpuGL.cpp

index b21043307016a6f0c2ee2a63163669f5c720bc5f..d318779284b2ecf83f81e8df4aa89eb6b69d1296 100644

--- a/src/gpu/gl/GrGpuGL.cpp

+++ b/src/gpu/gl/GrGpuGL.cpp

@@ -2482,7 +2482,6 @@ bool GrGpuGL::configToGLFormats(GrPixelConfig config,

break;

case kIndex_8_GrPixelConfig:

if (this->caps()->eightBitPaletteSupport()) {

- *internalFormat = GR_GL_PALETTE8_RGBA8;

// glCompressedTexImage doesn't take external params

*externalFormat = GR_GL_PALETTE8_RGBA8;

// no sized/unsized internal format distinction here

« no previous file with comments | « no previous file | no next file » | no next file with comments »