Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2401213002: Revert of Delete pre-MD code from OmniboxResultView (patchset #9 id:160001 of https://codereview.ch… (Closed)

Created:
4 years, 2 months ago by Jackie Quinn
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of Delete pre-MD code from OmniboxResultView (patchset #9 id:160001 of https://codereview.chromium.org/2365263006/ ) Reason for revert: The downstream Chrome on iOS code has never been ported to the new vector icon and still use MD raster icon. This CL breaks Chrome on iOS downstream (due to missing resources and removal of GetIcon() method). Original issue's description: > Delete pre-MD code from OmniboxResultView > > BUG=648281 > > Committed: https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707 > Cr-Commit-Position: refs/heads/master@{#423690} TBR=pkasting@chromium.org,blundell@chromium.org,sky@chromium.org,estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648281 Review-Url: https://codereview.chromium.org/2399333002 Cr-Commit-Position: refs/heads/master@{#423819} (cherry picked from commit 7ae88a32dfc5da7a3b0ad53f8d9ead92df14719c) Committed: https://chromium.googlesource.com/chromium/src/+/d63eff699899a0cbab355472582939c2a1d3e89a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -55 lines) Patch
M chrome/app/theme/theme_resources.grd View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 2 chunks +37 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/search/omnibox_result.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 11 chunks +97 lines, -24 lines 0 comments Download
M components/neterror/resources/neterror.css View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/autocomplete_match.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/omnibox/browser/autocomplete_match.cc View 2 chunks +61 lines, -0 lines 0 comments Download
M components/omnibox/browser/omnibox_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/omnibox/browser/omnibox_view.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M components/resources/components_scaled_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
D components/resources/default_100_percent/neterror/search_glass.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/controlled_setting_mandatory.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/ios/omnibox_history.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/ios/omnibox_history_incognito.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/ios/omnibox_http.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/ios/omnibox_http_incognito.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/ios/omnibox_https_invalid.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/ios/omnibox_https_valid.png View Binary file 0 comments Download
A + components/resources/default_100_percent/omnibox/ios/omnibox_search.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/ios/omnibox_search_incognito.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/location_bar_http.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/omnibox_calculator.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/omnibox_extension_app.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/omnibox_http.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/omnibox_https_invalid.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/omnibox_https_valid.png View Binary file 0 comments Download
A components/resources/default_100_percent/omnibox/omnibox_search.png View Binary file 0 comments Download
A + components/resources/default_100_percent/omnibox/omnibox_search_button_loupe.png View Binary file 0 comments Download
D components/resources/default_200_percent/neterror/search_glass.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/controlled_setting_mandatory.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/ios/omnibox_history.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/ios/omnibox_history_incognito.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/ios/omnibox_http.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/ios/omnibox_http_incognito.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/ios/omnibox_https_invalid.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/ios/omnibox_https_valid.png View Binary file 0 comments Download
A + components/resources/default_200_percent/omnibox/ios/omnibox_search.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/ios/omnibox_search_incognito.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/location_bar_http.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/omnibox_extension_app.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/omnibox_http.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/omnibox_https_invalid.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/omnibox_https_valid.png View Binary file 0 comments Download
A components/resources/default_200_percent/omnibox/omnibox_search.png View Binary file 0 comments Download
A + components/resources/default_200_percent/omnibox/omnibox_search_button_loupe.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/controlled_setting_mandatory.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/ios/omnibox_history.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/ios/omnibox_history_incognito.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/ios/omnibox_http.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/ios/omnibox_http_incognito.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/ios/omnibox_https_invalid.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/ios/omnibox_https_valid.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/ios/omnibox_search.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/ios/omnibox_search_incognito.png View Binary file 0 comments Download
A components/resources/default_300_percent/omnibox/omnibox_extension_app.png View Binary file 0 comments Download
A components/resources/omnibox_scaled_resources.grdp View 1 chunk +25 lines, -0 lines 0 comments Download
M components/toolbar/test_toolbar_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/toolbar/test_toolbar_model.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/toolbar/toolbar_model.h View 1 chunk +7 lines, -4 lines 0 comments Download
M components/toolbar/toolbar_model_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/toolbar/toolbar_model_impl.cc View 3 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jackie Quinn
4 years, 2 months ago (2016-10-07 22:43:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d63eff699899a0cbab355472582939c2a1d3e89a.

Powered by Google App Engine
This is Rietveld 408576698