Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2052)

Unified Diff: content/renderer/render_view_impl.cc

Issue 24012002: Move Range code to gfx. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: d Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_view_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 6ad5ca1e595b157cb382471b471f4a20b1606916..ae3794f41b4000546605893e7f9cf7194e583b35 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -791,7 +791,7 @@ RenderViewImpl::RenderViewImpl(RenderViewImplParams* params)
history_list_length_(0),
target_url_status_(TARGET_NONE),
selection_text_offset_(0),
- selection_range_(ui::Range::InvalidRange()),
+ selection_range_(gfx::Range::InvalidRange()),
#if defined(OS_ANDROID)
top_controls_constraints_(cc::BOTH),
#endif
@@ -1273,7 +1273,7 @@ void RenderViewImpl::SimulateImeSetComposition(
void RenderViewImpl::SimulateImeConfirmComposition(
const string16& text,
- const ui::Range& replacement_range) {
+ const gfx::Range& replacement_range) {
OnImeConfirmComposition(text, replacement_range, false);
}
@@ -2667,7 +2667,7 @@ void RenderViewImpl::showContextMenu(
selection_text_ = params.selection_text;
// TODO(asvitkine): Text offset and range is not available in this case.
selection_text_offset_ = 0;
- selection_range_ = ui::Range(0, selection_text_.length());
+ selection_range_ = gfx::Range(0, selection_text_.length());
Send(new ViewHostMsg_SelectionChanged(routing_id_,
selection_text_,
selection_text_offset_,
@@ -4170,7 +4170,7 @@ void RenderViewImpl::SendFindReply(int request_id,
bool RenderViewImpl::ShouldUpdateSelectionTextFromContextMenuParams(
const string16& selection_text,
size_t selection_text_offset,
- const ui::Range& selection_range,
+ const gfx::Range& selection_range,
const ContextMenuParams& params) {
string16 trimmed_selection_text;
if (!selection_text.empty() && !selection_range.is_empty()) {
@@ -4494,7 +4494,7 @@ void RenderViewImpl::SyncSelectionIfRequired() {
string16 text;
size_t offset;
- ui::Range range;
+ gfx::Range range;
#if defined(ENABLE_PLUGINS)
if (focused_pepper_plugin_) {
focused_pepper_plugin_->GetSurroundingText(&text, &range);
@@ -4507,7 +4507,7 @@ void RenderViewImpl::SyncSelectionIfRequired() {
if (!webview()->caretOrSelectionRange(&location, &length))
return;
- range = ui::Range(location, location + length);
+ range = gfx::Range(location, location + length);
if (webview()->textInputInfo().type != WebKit::WebTextInputTypeNone) {
// If current focused element is editable, we will send 100 more chars
@@ -5885,9 +5885,10 @@ void RenderViewImpl::OnImeSetComposition(
selection_end);
}
-void RenderViewImpl::OnImeConfirmComposition(const string16& text,
- const ui::Range& replacement_range,
- bool keep_selection) {
+void RenderViewImpl::OnImeConfirmComposition(
+ const string16& text,
+ const gfx::Range& replacement_range,
+ bool keep_selection) {
#if defined(ENABLE_PLUGINS)
if (focused_pepper_plugin_) {
// When a PPAPI plugin has focus, we bypass WebKit.
@@ -6042,7 +6043,7 @@ void RenderViewImpl::GetCompositionCharacterBounds(
}
}
-void RenderViewImpl::GetCompositionRange(ui::Range* range) {
+void RenderViewImpl::GetCompositionRange(gfx::Range* range) {
#if defined(ENABLE_PLUGINS)
if (focused_pepper_plugin_) {
return;
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_view_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698