bluetooth: Add Device service for chrome://bluetooth-internals.

chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc

Index: chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
diff --git a/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc b/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
index 74ac1664c20bbb2c600fd600061c4f8bfe6934bc..b2cea0ef82edfb5cd4131723469604ab247b26b8 100644
--- a/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
+++ b/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc
@@ -22,7 +22,10 @@ BluetoothInternalsUI::BluetoothInternalsUI(content::WebUI* web_ui)
                                IDR_BLUETOOTH_INTERNALS_JS);
   html_source->AddResourcePath(
       "device/bluetooth/public/interfaces/adapter.mojom",
-      IDR_BLUETOOTH_MOJO_JS);
+      IDR_BLUETOOTH_ADAPTER_MOJO_JS);
+  html_source->AddResourcePath(
+      "device/bluetooth/public/interfaces/device.mojom",

[dpapad, 2016/10/12 19:42:45]

+dbeam@chromium.org

Still catching up with the design doc at go/fizzbluetoothinternals. I am
noticing a discrepancy of the C++ code backing up chrome://bluetooth-internals
with the rest of WebUI. Specifically

C++ code handling messages from WebUI for all other WebUI pages resides at
chrome/browser/ui/webui/. For the case of bluetooth-internals, the only code
residing there (chrome/browser/ui/webui/bluetooth_internals) is a dummy
content::WebUIController subclass that simply serves the CSS and JS.

The JS files at chrome/browser/resources/bluetooth_internals/ are reaching out
to device/bluetooth directly, which seems a bit odd. Notice how all other
Mojo-ified WebUI pages (plugins/site-engagement,omnibox) have their *.mojom
files (and their implementations of those) inside chrome/browser/ui/webui.

Is it OK to
a) Have WebUI handling code outside of the so far established location
chrome/browser/ui/webui/?
b) Mix device/bluetooth code with WebUI handling code?

I am looping in more WebUI OWNERS. @dbeam: WDYT? Is this breaking existing
conventions in WebUI code structure?

[dpapad, 2016/10/12 21:02:32]

Talked about this with @dbeam in person. It seems that reaching outside of
chrome/browser/ui/webui directly is fine, there are already some examples of
doing so (some WebUI pages exist in content/ instead). Regarding mixing
device/bluetooth code with WebUI handling code, it still seems odd from my
perspective (Chrome's UI related code should live somewhere under chrome/,
top-level directories like device/, printing/ etc are considered lower-level
services not UI), but if device/bluetooth OWNERS are fine with that (already
LGed), then it is OK.

[mbrunson, 2016/10/12 23:20:03]

Great. scheib@ and ortuno@ are the device/bluetooth OWNERS, and I always add and
get LGTM from them first on this project.

+      IDR_BLUETOOTH_DEVICE_MOJO_JS);
   html_source->SetDefaultResource(IDR_BLUETOOTH_INTERNALS_HTML);
   html_source->DisableI18nAndUseGzipForAllPaths();