Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: device/bluetooth/public/interfaces/le_device.mojom

Issue 2401193002: bluetooth: Add Device service for chrome://bluetooth-internals. (Closed)
Patch Set: Add log function comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module bluetooth.mojom;
6
7 struct LEDeviceInfo {
8 string? name;
ortuno 2016/10/10 00:11:20 What about nameForDisplay? You will probably want
mbrunson 2016/10/10 19:21:28 Unless I'm missing something, GetNameForDisplay()
ortuno 2016/10/11 00:45:45 The purpose of GetNameForDisplay is not only to re
9 string id;
10 string address;
11 };
12
13 interface LEDevice {
ortuno 2016/10/10 00:11:20 Since this is just a thin wrapper around the curre
mbrunson 2016/10/10 19:21:28 I'll change it for now.
14 // Gets basic information about the device.
15 // Returns null, If no adapter is available.
ortuno 2016/10/10 00:11:20 nit: lower-case after comma. Also I think you mean
mbrunson 2016/10/10 19:21:28 Done.
16 GetInfo() => (LEDeviceInfo? info);
17 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698