device/bluetooth/public/interfaces/device.mojom - Issue 2401193002: bluetooth: Add Device service for chrome://bluetooth-internals.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/bluetooth/public/interfaces/device.mojom

Issue 2401193002: bluetooth: Add Device service for chrome://bluetooth-internals. (Closed)

Patch Set: Reorganizing, cleanup includes, add name for display Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module bluetooth.mojom;
	dpapad 2016/10/11 21:58:32 Does this have to be a different file for technica Does this have to be a different file for technical reasons? I personally would prefer to keep closely related interfaces in a single mojom file until there is a need to re-use DeviceInfo and Device from places where Adapter, AdapterClient etc are not used. mbrunson 2016/10/11 23:15:33 Less of a technical reason and more for organizati Show quoted text On 2016/10/11 21:58:32, dpapad wrote: > Does this have to be a different file for technical reasons? > > I personally would prefer to keep closely related interfaces in a single mojom > file until there is a need to re-use DeviceInfo and Device from places where > Adapter, AdapterClient etc are not used. Less of a technical reason and more for organization. The layout of the C++ implementation for the interfaces closely match the mojom declarations. We try to keep things separate conceptually unless it's necessary to keep them together.
	6

	7 struct DeviceInfo {

	8 string? name;

	9 string name_for_display;

	10 string address;

	11 };

	12

	13 interface Device {

	14 // Gets basic information about the device.

	15 // Returns null, If no device is available.
	dpapad 2016/10/11 21:58:32 Nit (optional): Maximize 80col usage before brakin Nit (optional): Maximize 80col usage before braking line? // Gets basic information about the device. Returns null, If no device is // available. mbrunson 2016/10/11 23:15:33 Done. Show quoted text On 2016/10/11 21:58:32, dpapad wrote: > Nit (optional): Maximize 80col usage before braking line? > > // Gets basic information about the device. Returns null, If no device is > // available. Done.
	16 GetInfo() => (DeviceInfo? info);

	17 };

OLD	NEW

« chrome/browser/resources/bluetooth_internals/bluetooth_internals.js ('K') | « device/bluetooth/public/interfaces/adapter.mojom ('k') | no next file » | no next file with comments »