Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 240113010: Tighten OpenHandle's extra checks. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix up rest #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -44 lines) Patch
M include/v8.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/accessors.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/api.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M src/objects.cc View 1 2 8 chunks +19 lines, -16 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 8 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 8 months ago (2014-04-25 09:18:43 UTC) #1
Yang
On 2014/04/25 09:18:43, Yang wrote: The main change is in api.h. It flushed out a ...
6 years, 8 months ago (2014-04-25 09:20:44 UTC) #2
Jakob Kummerow
lgtm
6 years, 8 months ago (2014-04-25 09:24:12 UTC) #3
Yang
6 years, 7 months ago (2014-04-28 13:42:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21022 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698