Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)
Patch Set: Callback cleanup, comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 3942d5a8db868a7333cc2964369f74e9d02bbe30..2e44da5c7081f8b83fd1ef9ea32f432d019b20f5 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -6676,7 +6676,7 @@ TEST_P(ParameterizedWebFrameTest, ModifiedClickNewWindow) {
PlatformMouseEvent::RealOrIndistinguishable, String(), nullptr);
FrameLoadRequest frameRequest(document, ResourceRequest(destination));
frameRequest.setTriggeringEvent(event);
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(UserGestureToken::create());
toLocalFrame(webViewHelper.webView()->page()->mainFrame())
->loader()
.load(frameRequest);
@@ -7398,7 +7398,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenLayerSize) {
webViewImpl->updateAllLifecyclePhases();
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(UserGestureToken::create());
Element* divFullscreen = document->getElementById("div1");
Fullscreen::requestFullscreen(*divFullscreen, Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7433,7 +7433,7 @@ TEST_F(WebFrameTest, FullscreenLayerNonScrollable) {
webViewImpl->updateAllLifecyclePhases();
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(UserGestureToken::create());
Element* divFullscreen = document->getElementById("div1");
Fullscreen::requestFullscreen(*divFullscreen, Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7477,7 +7477,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenMainFrame) {
webViewImpl->updateAllLifecyclePhases();
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(UserGestureToken::create());
Fullscreen::requestFullscreen(*document->documentElement(),
Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7518,7 +7518,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenSubframe) {
toWebLocalFrameImpl(webViewHelper.webView()->mainFrame()->firstChild())
->frame()
->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(UserGestureToken::create());
Element* divFullscreen = document->getElementById("div1");
Fullscreen::requestFullscreen(*divFullscreen, Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7562,7 +7562,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenWithTinyViewport) {
EXPECT_FLOAT_EQ(5.0, webViewImpl->maximumPageScaleFactor());
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(UserGestureToken::create());
Fullscreen::requestFullscreen(*document->documentElement(),
Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7599,7 +7599,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenResizeWithTinyViewport) {
LayoutViewItem layoutViewItem =
webViewHelper.webView()->mainFrameImpl()->frameView()->layoutViewItem();
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(UserGestureToken::create());
Fullscreen::requestFullscreen(*document->documentElement(),
Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
@@ -7661,7 +7661,7 @@ TEST_P(ParameterizedWebFrameTest, FullscreenRestoreScaleFactorUponExiting) {
{
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(UserGestureToken::create());
Fullscreen::requestFullscreen(*document->body(),
Fullscreen::PrefixedRequest);
}
@@ -7722,7 +7722,8 @@ TEST_P(ParameterizedWebFrameTest, ClearFullscreenConstraintsOnNavigation) {
EXPECT_FLOAT_EQ(5.0, webViewImpl->maximumPageScaleFactor());
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
- UserGestureIndicator gesture(DefinitelyProcessingUserGesture);
+ UserGestureIndicator gesture(
+ UserGestureToken::create(UserGestureToken::NewGesture));
Fullscreen::requestFullscreen(*document->documentElement(),
Fullscreen::PrefixedRequest);
webViewImpl->didEnterFullscreen();
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebUserGestureTokenTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698