third_party/WebKit/Source/web/WebPluginContainerImpl.cpp - Issue 2401123002: UserGestureIndicator is a mess. Clean it up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)

Patch Set: Callback cleanup, comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

index 32e9b9bfedd88bc54624c4b609752c429968e675..a971232ae0f0bd9c3c005480eb543729efe65e01 100644

--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

@@ -476,9 +476,9 @@ WebString WebPluginContainerImpl::executeScriptURL(const WebURL& url,

String script = decodeURLEscapeSequences(

kurl.getString().substring(strlen("javascript:")));

- UserGestureIndicator gestureIndicator(popupsAllowed

- ? DefinitelyProcessingNewUserGesture

- : PossiblyProcessingUserGesture);

+ UserGestureIndicator gestureIndicator(

+ popupsAllowed ? UserGestureToken::create(UserGestureToken::NewGesture)

+ : nullptr);

v8::HandleScope handleScope(toIsolate(frame));

v8::Local<v8::Value> result =

frame->script().executeScriptInMainWorldAndReturnValue(