third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp - Issue 2401123002: UserGestureIndicator is a mess. Clean it up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)

Patch Set: Callback cleanup, comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp

diff --git a/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp b/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp

index 8beacb12bd47c2fb683b944c573bd2177ad8ace9..9f0988fd292007d4f318a7ad2606bb40572dd310 100644

--- a/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp

+++ b/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp

@@ -54,8 +54,8 @@ WebScriptExecutor::WebScriptExecutor(

Vector<v8::Local<v8::Value>> WebScriptExecutor::execute(LocalFrame* frame) {

std::unique_ptr<UserGestureIndicator> indicator;

if (m_userGesture) {

- indicator = wrapUnique(

- new UserGestureIndicator(DefinitelyProcessingNewUserGesture));

+ indicator = wrapUnique(new UserGestureIndicator(

+ UserGestureToken::create(UserGestureToken::NewGesture)));

}

Vector<v8::Local<v8::Value>> results;