third_party/WebKit/Source/modules/notifications/Notification.cpp - Issue 2401123002: UserGestureIndicator is a mess. Clean it up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)

Patch Set: Callback cleanup, comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/notifications/Notification.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.cpp b/third_party/WebKit/Source/modules/notifications/Notification.cpp

index 2eb0af9c99864eae44d6d5722a872b0eaba12287..af9ad5b05de815721b36bc7ea43af3bf48a5b67a 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.cpp

+++ b/third_party/WebKit/Source/modules/notifications/Notification.cpp

@@ -208,7 +208,8 @@ void Notification::dispatchShowEvent() {

}

void Notification::dispatchClickEvent() {

- UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);

+ UserGestureIndicator gestureIndicator(

+ UserGestureToken::create(UserGestureToken::NewGesture));

ScopedWindowFocusAllowedIndicator windowFocusAllowed(getExecutionContext());

dispatchEvent(Event::create(EventTypeNames::click));

}