third_party/WebKit/Source/core/inspector/DevToolsHost.cpp - Issue 2401123002: UserGestureIndicator is a mess. Clean it up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)

Patch Set: Callback cleanup, comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

diff --git a/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp b/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

index ffb00b281a08054c21b56d010e286c6c6fc5c78d..c4a73f06836672638b2a4198786a1c5ce55b40ce 100644

--- a/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

+++ b/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp

@@ -132,7 +132,7 @@ void DevToolsHost::evaluateScript(const String& expression) {

if (!scriptState)

return;

ScriptState::Scope scope(scriptState);

- UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);

+ UserGestureIndicator gestureIndicator(UserGestureToken::create());

v8::MicrotasksScope microtasks(scriptState->isolate(),

v8::MicrotasksScope::kRunMicrotasks);

v8::Local<v8::String> source =