third_party/WebKit/Source/core/input/KeyboardEventManager.cpp - Issue 2401123002: UserGestureIndicator is a mess. Clean it up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

Issue 2401123002: UserGestureIndicator is a mess. Clean it up. (Closed)

Patch Set: Callback cleanup, comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

index c60a3ee76c308c14bd275a356f3ff12a8b1d0e67..eaa25b9ba498ad7754f8eb809e77f5180d1eb79d 100644

--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

@@ -104,7 +104,7 @@ WebInputEventResult KeyboardEventManager::keyEvent(

if (!node)

return WebInputEventResult::NotHandled;

- UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);

+ UserGestureIndicator gestureIndicator(UserGestureToken::create());

// In IE, access keys are special, they are handled after default keydown

// processing, but cannot be canceled - this is hard to match. On Mac OS X,